Changeset 927d0c70c763dcf56e6f12ebe02a51688468a5c3 for src/rh-config.c

Timestamp:

06/08/09 21:12:46 (3 years ago)

Author:

Neutron Soutmun <neo.neutron@…>

Children:

bae014d9f22e13f6115d53d154e6489f20ae00e4

Parents:

5987af1b79b0c1fbd4aa9d30a53ec6879853ece3

git-committer:

Neutron Soutmun <neo.neutron@…> (06/08/09 21:12:46)

Message:

Follow the flawfinder guideline

• Reduce the vulnerability code by follow the advice of flawfinder.
• Just finish one of the TODO lists.

Files:

• src/rh-config.c (modified) (3 diffs)

src/rh-config.c

@@ -370 +370 @@
     {
       iface = (struct interfaces *)runner->data;
-      if (strncmp(iface->dev_internal, inf_name, strlen(inf_name)) == 0)
+      if (iface->dev_internal &&
+          strncmp(iface->dev_internal, inf_name, strlen(inf_name)) == 0)
         {
           // Already in the list
@@ -388 +389 @@
     }
 
-  strncpy(item->dev_internal, inf_name, 32);
-  sprintf(item->dev_ifb, "ifb%d", ifb_ifno);
+  strncpy(item->dev_internal, inf_name, sizeof (item->dev_internal));
+  snprintf(item->dev_ifb, sizeof (item->dev_ifb), "ifb%d", ifb_ifno);
   item->init = 0;
   item->hit  = 1;
@@ -411 +412 @@
     {
       iface = (struct interfaces *)runner->data;
-      if (strncmp (iface->dev_internal, inf_name, strlen (inf_name)) == 0)
+      if (iface->dev_internal &&
+          strncmp (iface->dev_internal, inf_name, strlen (inf_name)) == 0)
         {
           iface->hit--;