Changeset 927d0c70c763dcf56e6f12ebe02a51688468a5c3 for src/rh-task-bandwidth.c

Timestamp:

06/08/09 21:12:46 (3 years ago)

Author:

Neutron Soutmun <neo.neutron@…>

Children:

bae014d9f22e13f6115d53d154e6489f20ae00e4

Parents:

5987af1b79b0c1fbd4aa9d30a53ec6879853ece3

git-committer:

Neutron Soutmun <neo.neutron@…> (06/08/09 21:12:46)

Message:

Follow the flawfinder guideline

• Reduce the vulnerability code by follow the advice of flawfinder.
• Just finish one of the TODO lists.

Files:

• src/rh-task-bandwidth.c (modified) (2 diffs)

src/rh-task-bandwidth.c

@@ -282 +282 @@
   
   // Formating the bandwidth request
-  sprintf(bw_req.ip, "%s", idtoip(vs->v_map, req->id));
-  sprintf(bw_req.bandwidth_max_down, "%lu", 
-    member->bandwidth_max_down);
-  sprintf(bw_req.bandwidth_max_up, "%lu", 
-    member->bandwidth_max_up);
+  snprintf(bw_req.ip, sizeof (bw_req.ip), "%s", idtoip(vs->v_map, req->id));
+  snprintf(bw_req.bandwidth_max_down, sizeof (bw_req.bandwidth_max_down), 
+           "%lu", member->bandwidth_max_down);
+  snprintf(bw_req.bandwidth_max_up, sizeof (bw_req.bandwidth_max_up), "%lu", 
+           member->bandwidth_max_up);
   
   while (max_try > 0) { 
     slot_id = _get_slot_id();
-    sprintf(bw_req.slot_id, "%d", slot_id);
+    snprintf(bw_req.slot_id, sizeof (bw_req.slot_id), "%d", slot_id);
     if (bandwidth_add(vs, &bw_req) == 0)
       break;
@@ -328 +328 @@
     return 0;
 
-  sprintf(bw_req.slot_id, "%d", slot_id);
+  snprintf(bw_req.slot_id, sizeof (bw_req.slot_id), "%d", slot_id);
 
   if (bandwidth_del(vs, &bw_req) == 0) {