Changeset 927d0c70c763dcf56e6f12ebe02a51688468a5c3 for src/rh-task-dbset.c

Timestamp:

06/08/09 21:12:46 (3 years ago)

Author:

Neutron Soutmun <neo.neutron@…>

Children:

bae014d9f22e13f6115d53d154e6489f20ae00e4

Parents:

5987af1b79b0c1fbd4aa9d30a53ec6879853ece3

git-committer:

Neutron Soutmun <neo.neutron@…> (06/08/09 21:12:46)

Message:

Follow the flawfinder guideline

• Reduce the vulnerability code by follow the advice of flawfinder.
• Just finish one of the TODO lists.

Files:

• src/rh-task-dbset.c (modified) (3 diffs)

src/rh-task-dbset.c

@@ -294 +294 @@
                  GDA_CONNECTION_OPTIONS_READ_ONLY, NULL);
 
-  sprintf(select_cmd, "SELECT * FROM dbset WHERE vserver_id='%d'",
-          vs->vserver_config->vserver_id);
+  snprintf(select_cmd, sizeof (select_cmd), 
+           "SELECT * FROM dbset WHERE vserver_id='%d'",
+           vs->vserver_config->vserver_id);
 
   DP("SQL: %s", select_cmd);
@@ -343 +344 @@
   member = (struct rahunas_member *) member_node->data;
 
-  sprintf(startsess_cmd, "INSERT INTO dbset"
+  snprintf(startsess_cmd, sizeof (startsess_cmd), "INSERT INTO dbset"
          "(session_id,vserver_id,username,ip,mac,session_start,"
          "session_timeout,bandwidth_slot_id,bandwidth_max_down,"
@@ -394 +395 @@
   DP("SessionID : %s", member->session_id);
 
-  sprintf(stopsess_cmd, "DELETE FROM dbset WHERE "
+  snprintf(stopsess_cmd, sizeof (stopsess_cmd), "DELETE FROM dbset WHERE "
          "session_id='%s' AND username='%s' AND vserver_id='%d'",
          member->session_id,